[patch] Xircom REM56G-100

[f***@newipnet.com]

Hello,

Here's a patch for Xircom Ethernet cards REM56G and I think CEM56 to work
(Realports).
There's a problem in the current driver that prevent these cards to work
failing with errors:
xe0: Cannot allocate ioport
device_probe_and_attach: xe0 attach returned 12

It fails in OLDCARD and NEWCARD, as the problem is in the driver.

Problem is related to a simple error in a for.

--- xe/if_xe_pccard.c Fri Apr 2 17:13:37 2004
+++ xenew/if_xe_pccard.c Fri Apr 2 17:14:52 2004
@@ -271,7 +271,7 @@
scp->card_type = card_itm->card_type_desc;
if (card_itm->prod_type & XE_PROD_MODEM_UMASK)
scp->modem = 1;
- for(i=1; i!=XE_CARD_TYPE_FLAGS_DINGO; i=i<<1) {
+ for(i=1; i<=XE_CARD_TYPE_FLAGS_DINGO; i=i<<1) {
switch(i & card_itm->flags) {
case XE_CARD_TYPE_FLAGS_CE2:
scp->ce2 = 1; break;



Regards,
Carlos Velasco

[scott+]

Post by f***@newipnet.com
Hello,
Here's a patch for Xircom Ethernet cards REM56G and I think CEM56 to work
(Realports).

Hi Carlos,

Thanks for this -- I think I have everything but a CEM56/REM56 here for
testing, so I would never have spotted this one myself.

I have patches here for the same file that fix probing of various cards
(there were some that worked with OLDCARD but not NEWCARD, and vice-versa).
These should cover the case you've found as well, but I'll check this and
try to get something committed asap.

Cheers,

Scott

[s***@renesas.com]

Hi, scott-san.

Post by f***@newipnet.com
Here's a patch for Xircom Ethernet cards REM56G and I think CEM56 to work
(Realports).

Scott> Thanks for this -- I think I have everything but a CEM56/REM56 here for
Scott> testing, so I would never have spotted this one myself.

I'm sorry my mistake when I seperated if_xe_pccard.c from if_xe.c.
I don't have had a DINGO card, so have never tested.

Scott> I have patches here for the same file that fix probing of various cards
Scott> (there were some that worked with OLDCARD but not NEWCARD, and vice-versa).
Scott> These should cover the case you've found as well, but I'll check this and
Scott> try to get something committed asap.

I hope you work for this problem. BTW, Does a xircom multi-function card
work now?

Takeshi Shibagaki